-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
convert std::cout and std::cerr to std::println() #8085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also if you could split those into 3 commits:
- hyprland
- hyprpm
- hyprctl
then I could just rebase it on main.
ye thats whatever both look alr |
Sorry wdym? |
Squash all commits into one, then split that one commit into three, each changing only one component (hyprland, hyprctl, hyprpm) so it's
|
done |
btw bump |
no |
let me know if there is anything else I missed or should changes, so I can rebase into 3 commits again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
yeah ofc, was just waiting for approval |
Describe your PR, what does it fix/add?
follow up from #8034
std::print()
is easier to use and read, it also has better performance and reduces boilerplate code https://vitaut.net/posts/2023/print-in-cpp23/Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
So I have almost converted every instance of
std::cout
, I only left some for example wherehyprpm
prints the warning message when adding a plugin and there were too many Colors, so I left those for the sake of readability.I have added
hyprpm/src/helpers/StringUtils.hpp
which is useful to replace the boilerplate such aswith
Is it ready for merging, or does it need work?
Yeah, hope I didn't do too much or some things must be in a separeted MR. This took me the whole day. Did some tests and seems good so far