Skip to content

IBX-9414: Bookmarks list fixes #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

IBX-9414: Bookmarks list fixes #1553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b77ee3
IBX-9414: Bookmarks list fixes
albozek May 21, 2025
ae918d6
Removed duplicated CSS class
albozek May 23, 2025
cd2f18f
after review
albozek May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/bundle/Resources/public/scss/_main-container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,14 @@
}
}

&--full-width {
.container {
@media (min-width: 1200px) {
max-width: calculateRem(2000px);
}
}
}

.ibexa-content-container {
display: flex;
flex-direction: column;
Expand Down
4 changes: 2 additions & 2 deletions src/bundle/Resources/translations/ibexa_bookmark.en.xliff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
</header>
<body>
<trans-unit id="5cc4d552faa942983e3eb8ec85c053aeb1e42ae4" resname="bookmark.button.remove">
<source>Delete</source>
<target state="new">Delete</target>
<source>Remove from bookmarks</source>
<target state="new">Remove from bookmarks</target>
<note>key: bookmark.button.remove</note>
</trans-unit>
<trans-unit id="c2c1dc512033aabc10e0c6a46cf5e99355f5c750" resname="bookmark.headline">
Expand Down
5 changes: 3 additions & 2 deletions src/bundle/Resources/views/themes/admin/account/bookmarks/list.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
{% form_theme form_remove '@ibexadesign/ui/form_fields.html.twig' %}

{% block body_class %}ibexa-bookmark-list-view{% endblock %}
{% block main_container_class %}{{ parent() }} ibexa-main-container--full-width {% endblock %}

{% block header %}
{% include '@ibexadesign/ui/page_title.html.twig' with {
Expand Down Expand Up @@ -92,7 +93,7 @@
{ },
],
body_rows,
actions: form_widget(form_remove.remove, {'attr': {'class': 'btn ibexa-btn ibexa-btn--ghost ibexa-btn--small', 'disabled': true}}),
actions: form_widget(form_remove.remove, {'attr': {'class': 'btn ibexa-btn ibexa-btn--ghost ibexa-btn--small', 'disabled': true} }),
empty_table_info_text: 'bookmark.list.empty'|trans|desc('You have no bookmarks yet. Your bookmarks will show up here.'),
} %}
{{ form_end(form_remove) }}
Expand All @@ -108,7 +109,7 @@
'action': path('ibexa.content.edit'),
'attr': { 'class': 'ibexa-edit-content-form'}
}) }}
{{ form_widget(form_edit.language, {'attr': {'hidden': 'hidden', 'class': 'language-input'}}) }}
{{ form_widget(form_edit.language, {'attr': {'hidden': 'hidden', 'class': 'language-input'} }) }}
{{ form_end(form_edit) }}
</div>
{% endblock %}
Expand Down
2 changes: 1 addition & 1 deletion src/bundle/Resources/views/themes/admin/ui/form_fields.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@
{%- endblock table_header_tool_btn -%}

{%- block _bookmark_remove_remove_widget -%}
{%- set title = 'bookmark.button.remove'|trans({},'ibexa_bookmark')|desc('Delete') -%}
{%- set title = 'bookmark.button.remove'|trans({},'ibexa_bookmark')|desc('Remove from bookmarks') -%}
{%- set icon = 'trash' -%}
{{ block('table_header_tool_btn') }}
{%- endblock -%}
Expand Down
Loading