IBX-9447: Added a missing condition when verifying the Asset field #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adamwojs
approved these changes
Mar 3, 2025
konradoboza
approved these changes
Mar 3, 2025
barbaragr
approved these changes
Mar 7, 2025
alongosz
reviewed
Mar 7, 2025
There was a problem hiding this comment.
As a follow-up, I'd encourage you to add some integration test coverage for the bug, to protect ourselves from reintroducing this bug in the future (e.g.: during code upgrades or merge ups).
From the issue description seems like this is rather straightforward to reproduce for the integration test suite.
Merging this one :)
alongosz
deleted the
IBX-9447-Changing-fieldtype-under-the-same-identifier-causes-an-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The added condition already exists when verifying field type relations, so it has also been adapted when verifying Asset type relations.