RFC: Added siteaccess option to application definition, instead of per command

[Steveb-p]

🎫 Issue	IBX-10428

Description:

This is a follow-up PR for #634 that contains a different solution, which changes how the siteaccess option is added.

This ensures that invokable commands also receive --siteaccess as an option, without the need to add

#[Option('siteaccess')
?string $siteaccess = null

to command explicitly.

For QA:

Documentation:

[Copilot]

Pull Request Overview

This PR refactors how the siteaccess option is added to console commands by moving from a compiler pass approach to an application-level event listener. Instead of adding the option to individual command definitions during container compilation, the new approach adds the option to the application's input definition when any command is executed.

Key changes:

• Replaces per-command option injection with application-level option registration
• Ensures invokable commands receive the --siteaccess option without explicit configuration
• Removes the need for manual option declaration in command classes

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/bundle/Core/EventListener/ApplicationCommandListener.php	New event listener that adds siteaccess option to application definition on command execution
src/bundle/Core/Resources/config/services.yml	Registers the new ApplicationCommandListener as an event subscriber
src/bundle/Core/IbexaCoreBundle.php	Removes the ConsoleCommandPass compiler pass registration
src/bundle/Core/DependencyInjection/Compiler/ConsoleCommandPass.php	Removes the compiler pass that added siteaccess option to individual commands
tests/bundle/Core/DependencyInjection/Compiler/ConsoleCommandPassTest.php	Removes tests for the deleted compiler pass

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The class is missing a docblock that explains its purpose. Consider adding a class-level docblock to describe that this listener adds the siteaccess option to the application's input definition for all console commands.

[Copilot]

The magic number 256 for the event priority lacks explanation. Consider adding a comment explaining why this specific priority is chosen, especially since it's quite high and suggests it needs to run before other listeners.

Suggested change

	ConsoleEvents::COMMAND => [
	ConsoleEvents::COMMAND => [
	// Use a high priority (256) to ensure this listener runs before other listeners,
	// so that the 'siteaccess' option is available as early as possible.

[adamwojs]

declare(strict_types=1); is missing

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud