Adds support for mirrored label text direction #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect! |
|
@imaNNeo I fixed the tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
+ Coverage 92.43% 92.47% +0.04%
==========================================
Files 46 46
Lines 3344 3364 +20
==========================================
+ Hits 3091 3111 +20
Misses 253 253
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I see you didn't write new tests. Please write some tests to resolve the tests pipeline here |
|
Can you please rebase your branch? |
…s own touchData for example, lineTouchData, barTouchData, ...)
…e the basic information about our brand new CandlestickChart
… canvas (based on the scatter painter)
…have the full structure of having candlesticks, let's implement a sample
…in our axis-based charts
…ur candle_stick_chart to draw the touched/hoverer point
…k helper painters
…k_chart_painter_test.dart
…sponse objects (LineTouchResponse, BarTouchResponse, ...)
…dicator to allow user to customize the touch lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
HorizontalLineLabelandVerticalLineLabelsupport.horizontaland.verticaldirection but there is no way (afaik) how to flip the text upside down along this direction. This is a problem mainly for vertical direction where the text is upside down (in relation to axis names).This PR adds additional label direction options:
.horizontalMirroredand.verticalMirroredwhich would flip the text upside down. This is not a breaking change.