Fix announce of processes on Windows. #767
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added type annotations to the fsm.py file and used ruff (vscode) to: - Black-compatible code formatting. - fix all auto-fixable violations, like unused imports. - isort-compatible import sorting. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
And move it out of the fsm.py file. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
This commit adds cross-platform process announcement to Instana Host Agents. The implementation gracefully handles platform differences, ensuring consistent process information on both Unix and Windows environments: - Created a new `_get_cmdline()` function to return the command line of the current monitored process independently of the running platform. - Created the `_get_cmdline_windows()` function to return the command line on Windows machines. - Created `_get_cmdline_unix()` that returns the command line in Unix machines. It decides how to collect the information by running either the ` _get_cmdline_linux_proc()` or the `_get_cmdline_unix_ps()`. - Refactored the `_setup_socket_connection()` function. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
TheMachineandDiscoveryclasses by adding type annotations to thefsm.pyfile and usingruff.Discoveryclass by changing it to aDataClass, and move it out of the fsm.py file._get_cmdline()function to return the command line of the current monitored process independently of the running platform._get_cmdline_windows()function to return the command line on Windows machines._get_cmdline_unix()that returns the command line in Unix machines. It decides how to collect the information by running either the_get_cmdline_linux_proc()or the_get_cmdline_unix_ps()._setup_socket_connection()function.Signed-off-by: Paulo Vital paulo.vital@ibm.com