Skip to content

Commit f3779c1

Browse files
Pavel Chupinbadersmaslov-intel
authored
Apply suggestions from code review
Co-authored-by: Alexey Bader <alexey.bader@intel.com> Co-authored-by: smaslov-intel <48694368+smaslov-intel@users.noreply.github.com>
1 parent 1f468b3 commit f3779c1

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

sycl/plugins/level_zero/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,9 @@ endif()
136136

137137
add_dependencies(sycl-toolchain pi_level_zero)
138138
target_link_libraries(pi_level_zero
139-
PRIVATE "${LEVEL_ZERO_LOADER}"
140-
PRIVATE OpenCL-Headers
139+
PRIVATE
140+
"${LEVEL_ZERO_LOADER}"
141+
OpenCL-Headers
141142
)
142143

143144
if (UNIX)

sycl/plugins/opencl/CMakeLists.txt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66

77
# Plugin for OpenCL
88
# Create Shared library for libpi_opencl.so.
9-
#TODO: remove dependency on pi.hpp in sycl project.
9+
#TODO: remove dependency on pi.h in sycl project.
1010
#TODO: Currently, the pi.h header is common between sycl and plugin library sources.
11-
#This can be changed by copying the pi.hpp file in the plugins project.
11+
#This can be changed by copying the pi.h file in the plugins project.
1212

1313
add_library(pi_opencl SHARED
1414
"${sycl_inc_dir}/CL/sycl/detail/pi.h"
@@ -24,8 +24,9 @@ target_include_directories(pi_opencl PRIVATE "${sycl_inc_dir}")
2424

2525
#link pi_opencl with OpenCL headers and ICD Loader.
2626
target_link_libraries(pi_opencl
27-
PRIVATE OpenCL-Headers
28-
PRIVATE OpenCL-ICD
27+
PRIVATE
28+
OpenCL-Headers
29+
OpenCL-ICD
2930
)
3031
if (MSVC)
3132
# by defining __SYCL_BUILD_SYCL_DLL, we can use __declspec(dllexport)

sycl/unittests/pi/cuda/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ target_include_directories(PiCudaTests
2121
PRIVATE
2222
"../"
2323
"${sycl_inc_dir}/CL/sycl/detail/"
24-
${sycl_inc_dir}
24+
"${sycl_inc_dir}"
2525
"${sycl_plugin_dir}/cuda/"
2626
)
2727

0 commit comments

Comments
 (0)