[CI][NFC] Clarify the breaking of the opportunistic_group #19774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies the break of sycl-rel 6.2 opportunistic_group test due to the removal of the corresponding device aspect in intel#19238 following the refactoring of the experimental extension. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sure! The other PR isn't merged yet either, so I will go change it. For the future, might it be better to make the need for a approval/clarification on each of those lines? Having to move these into the same place is going to cause all incoming clarifications to conflict. |
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
|
The expectation is that going forward we won't need to make it post-factum, so there will be no section in the file, everything will be solid/containing necessary explanations. |
aelovikov-intel
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies the break of sycl-rel 6.2 opportunistic_group test due to the removal of the corresponding device aspect in #19238 following the refactoring of the experimental extension.