Skip to content

Conversation

anthonyduong9
Copy link
Collaborator

@anthonyduong9 anthonyduong9 commented Jul 23, 2025

Description

Adds "batchtopk" to choices for the --architecture arg in the training CLI. We want to be able to train BatchTopK SAEs using the CLI, and didn't add the logic for this in #505.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and tests

  • I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

Performance Check.

If you have implemented a training change, please indicate precisely how performance changes with respect to the following metrics:

  • L0
  • CE Loss
  • MSE Loss
  • Feature Dashboard Interpretability

Please links to wandb dashboards with a control and test group.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (7ceb4ab) to head (620c017).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   85.53%   85.53%           
=======================================
  Files          28       28           
  Lines        3587     3588    +1     
  Branches      448      448           
=======================================
+ Hits         3068     3069    +1     
  Misses        336      336           
  Partials      183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@chanind chanind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops great catch!

@anthonyduong9 anthonyduong9 marked this pull request as ready for review July 24, 2025 03:01
@anthonyduong9 anthonyduong9 merged commit 9c758f7 into main Jul 25, 2025
5 checks passed
@anthonyduong9 anthonyduong9 deleted the add-batchtopk-to-architecture-choices branch July 25, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants