fast-export (and fast-import) of signed commits

[castedo]

Any guidance on whether Dulwich fastexport of the python-fastimport library support signed commits?

Today i unexpectedly discovered that the current version of git (cgit) does not support signed commits! But there are plans to add a feature to support this soon (https://gitlab.com/gitlab-org/git/-/issues/457).

I can't tell quickly from the codebases whether Dulwich fastexport of the python-fastimport library support signed commits. It kinds of looks like they do not support but I'm not sure (given that cgit doesn't support it yet this is not that surprising).

[castedo]

I did the following quick test on a repo with a signed commit. The output does not have the commit signature. So between looking at the source code and this test I'm pretty sure Dulwich fast-export does not support signed commits.

from dulwich.fastexport import GitFastExporter
import dulwich.repo

repo = dulwich.repo.Repo(".")
ref = b'refs/heads/main'
with open('/dev/stdout', 'wb') as fout:
  fastexporter = GitFastExporter(fout, repo.object_store)
  fastexporter.emit_commit(repo[ref], ref)

[jelmer]

Yeah, pretty sure we strip as well today. Patches to preserve signatures (compatible with upstream C Git) would be welcome.