Implement BigInt asIntN and asUintN methods #5165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergocs
force-pushed
the
bigintFix
branch
2 times, most recently
from
d4ba173 to
4a2983c
Compare
|
Please add this line before the signed off: |
gergocs
force-pushed
the
bigintFix
branch
2 times, most recently
from
c812ef9 to
84a067c
Compare
robertsipka
requested changes
Nov 19, 2024
LaszloLango
reviewed
Nov 20, 2024
LaszloLango
requested changes
Nov 20, 2024
The following methods were implemented: - BigInt.asIntN - BigInt.asUintN Custom dispatcher also added to builtin_bigint. The implementation is based on PR jerryscript-project#4736, only applied the requested changes. Co-authored-by: Daniel Batiz batizjob@gmail.com JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following methods were implemented:
Custom dispatcher also added to builtin_bigint.
The implementation is based on PR #4736, only applied the requested changes.
Co-authored-by: Daniel Batiz batizjob@gmail.com
Signed-off-by: Gergo Csizi gergocs@inf.u-szeged.hu