-
Notifications
You must be signed in to change notification settings - Fork 34
feat(ci): GitHub action for pull requests #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat(ci): GitHub action for pull requests #24
Conversation
b9e74e0
to
61db806
Compare
You can see this in action on my fork: https://github.com/timothystewart6/cloud-api/actions/runs/13469922327/job/37642166583?pr=3 |
Looks great! We'll likely need to change it to use the BuildJet runners, but I assume Adam or Lian will need to do that. |
@Nevexo Thanks! I am unsure why it would take specialized runners considering it's just a NodeJS app and I have already been building this container on my fork without any issues. |
Because BulildJet make the JetKVM 😉 |
Got it, I assume you mean the native piece or something else? Public runners like this would work just fine I assume as you can see above. The container is already built on my fork and is publicly accessible through GitHub. Not sure why it would take specialized, private runners to do this but maybe I am missing something 😅 |
any movement on this? or explanation on why it can't use default github runners? @Nevexo |
I have no updates on it, it's out of my control - there's no reason why it can't run on public runners, but since it's a BuildJet product they'll probably want to use their own runners lol |
A simple action for pull requests that installs dependencies, transpiles TypeScript to JavaScript, and generates schemas on every pull request. Ideally this would be a great place for linting and tests however neither have bee adopted.
Depends on #22