fix: Add retry mechanism for recording sounds to handle async audio loading #16310
+91
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Recording sounds (RECORDING_OFF_SOUND, RECORDING_ON_SOUND, etc.) were being played before the audio files finished loading, causing console warnings like:
PLAY_SOUND: no sound found for id: RECORDING_OFF_SOUND
This happened because:
onCanPlayThrough
event firesSolution
BaseApp._extraInit()
to register sounds as early as possible