fix(ios): prevent duplicate CallKit endCall transaction #16376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
|
signed the cla, do i need to provide something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s the problem?
When endCall is invoked in CallKit, duplicate CXEndCallAction transactions can be requested if the UUID is invalid or handled multiple times. This may cause inconsistent behavior or unexpected errors on iOS.
What does this fix do?
Validates the callUUID before creating an CXEndCallAction.
Ensures that only valid transactions are sent to CallKit.
Prevents duplicate or invalid transactions that can break call termination.
How was this tested?
Triggered endCall with a valid callUUID → call ends as expected.
Triggered endCall with an invalid callUUID → returns error early, no duplicate transaction created.
Verified logs show correct behavior.
Related Issues
Fixes #<16365>