Add testing on newer versions of DRF and Django #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last DRF version to support Django 1.8, which is the latest Django version which is included in the test matrix.
This adjusts Travis to match the testing matrix set up within Tox.
This adjusts the Tox requirements to use the `.*` format to pick up the latest version in the range, so we don't need to worry about pinning to a specific version and having a newer patch release come out later down the line.
While these supports versions past DRF 3.6, this commit is only adding matrix support up to 3.6 for now to minimize overall changes.
At this point the testing matrix is massive, somewhere in the range of 80 different builds. This should probably get cut down at some point, but that would likely warrant breaking changes or a stable version support policy (which doesn't currently appear to exist).
These two versions only support Django 1.10 and Django 1.11, so that makes testing a bit easier and reduces the number of new matrix combinations.
This is only supported by two versions of Django REST framework, since it's a relatively recent release.
Django 2.0 does not support Python 2.7 and Python 3.3, so it is not tested on those combinations. It's only tested on Python 3.4. We are now almost at 100 combinations on Travis...
|
@kevin-brown thank you so much for this ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library hasn't changed much and still appears to be supported in newer versions of Django REST framework, but it's difficult to verify because the test matrix stops at DRF 3.1. This updates the test matrix for newer versions of DRF.
Changes:
This maintains testing and support for the existing DRF and Django combinations, since no code changes were necessary to support newer combinations.