Skip to content

Test that filter expression literals must be compared #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2024
Merged

Test that filter expression literals must be compared #81

merged 1 commit into from
May 18, 2024

Conversation

jg-rp
Copy link
Contributor

@jg-rp jg-rp commented May 17, 2024

Test that filter expression literals must be compared, unless they're inside a function expression.

@jg-rp jg-rp mentioned this pull request May 17, 2024
Merged
gregsdennis
gregsdennis approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good by eye. I'll run it through my implementation tomorrow.

f3ath
f3ath approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@f3ath f3ath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and passes on my implementation

@gregsdennis
Copy link
Collaborator

Somehow $[?2] and $[?'abc'] don't fail for me. But they should.

@gregsdennis gregsdennis merged commit 466da9d into jsonpath-standard:main May 18, 2024
@jg-rp jg-rp mentioned this pull request May 20, 2024
Merged
@jg-rp jg-rp deleted the literal-comparison branch June 23, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f3ath f3ath f3ath approved these changes

@gregsdennis gregsdennis gregsdennis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jg-rp @gregsdennis @f3ath