Use filelock while starting a new kernel. #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to Qiskit/documentation
that referenced
this pull request
May 16, 2025
This PR uses a lock to try and avoid this error when running in a GitHub action: ``` zmq.error.ZMQError: Address already in use (addr='tcp://127.0.0.1:45769') ``` This is a bit of a shot in the dark because I can't reproduce it locally. This is related to #2387, but is not necessarily a full fix as I believe there is more than one thing going on there. *** Inspired by jupyter/nbclient#327
|
I am hitting this using Snakemake's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use nbmake and pytest-xdist to run many notebook tests in parallel on a CI machine with 64 cores. This frequency triggers the long standing
jupyter_clientbug jupyter/jupyter_client#487 whose proposed solution is detailed in a Jupyter enhancement proposal accepted in 2023 -- jupyter/enhancement-proposals#66.When launch many local kernels, the obvious solution seems to be to hold a file lock during kernel start up. This PR implements that solution using https://github.com/tox-dev/filelock.
I've put up this PR without any tests yet as a request for feedback.
Questions:
Many thanks to wandb/wandb#8835 for the idea behind the PR.