Skip to content

feat(logs): allow LogShipper to filters on flowId and executionId #10347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(logs): allow LogShipper to filters on flowId and executionId #10347

wants to merge 1 commit into from

Conversation

loicmathieu
Copy link
Member

@github-project-automation github-project-automation bot moved this to To review in Pull Requests Jul 25, 2025
@loicmathieu loicmathieu requested a review from AcevedoR July 25, 2025 09:35
AcevedoR
AcevedoR approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@AcevedoR AcevedoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you could add a test in EE for the whole change

@loicmathieu
Copy link
Member Author

There are test in EE, the change to the repository method are tested as it's an abstract base test

@loicmathieu loicmathieu force-pushed the feat/executionId-LogShipper branch from a0c7b38 to 5054584 Compare July 25, 2025 10:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AcevedoR AcevedoR AcevedoR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pull Requests
Status: To review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicmathieu @AcevedoR