Skip to content

Conversation

dcslagel
Copy link
Collaborator

Description:

This change addresses "Correctly reading a LAS file with an empty ~Other" section #417

Changes

  • This change prevents ~Other parsing from reading ~ASCII data
    So if the ~Other section is empty in the las file it will be empty in
    the internal las structure.
  • Test case added: test_read_v2_sample_empty_other_section

Test Results

No change:

Name                       Stmts   Miss  Cover
----------------------------------------------
lasio/__init__.py             13      2    85%
lasio/convert_version.py      20     20     0%
lasio/defaults.py             11      0   100%
lasio/examples.py             42     10    76%
lasio/excel.py                88     34    61%
lasio/exceptions.py            6      0   100%
lasio/las.py                 409     59    86%
lasio/las_items.py           199     31    84%
lasio/las_version.py          50     14    72%
lasio/reader.py              396     25    94%
lasio/writer.py              175     10    94%
----------------------------------------------
TOTAL                       1409    205    85%

--

Let me know if this change could be accepted (or rejected) or
needs some additional changes to be approved and merged.

Thank you,
DC

- This change prevents ~Other parsing from reading ~ASCII data
  So if the ~Other section is empty in the las file it will be empty in
  the internal las structure.
- Test case added: test_read_v2_sample_empty_other_section
@kinverarity1 kinverarity1 merged commit c94833b into kinverarity1:master Mar 16, 2021
@kinverarity1
Copy link
Owner

Thanks!

@dcslagel dcslagel deleted the fix-parsing-for-empty-other-section branch March 17, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants