Skip to content

chore: viaIR compilation enabled for Foundry with explicit solc v0.8.30 #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

jaybuidl
Copy link
Member

@jaybuidl jaybuidl commented Aug 7, 2025

Also bumped @kleros/vea-contracts to v0.7.0


PR-Codex overview

This PR primarily focuses on updating the version of the @kleros/vea-contracts package from 0.6.0 to 0.7.0 across various configuration files and adjusting optimization settings in the hardhat.config.ts file.

Detailed summary

  • Updated @kleros/vea-contracts version from 0.6.0 to 0.7.0 in package.json and yarn.lock.
  • Increased optimizer runs from 100 to 10000 in hardhat.config.ts.
  • Updated Solidity compiler version to 0.8.30 in foundry.toml.
  • Added new optimizer settings in foundry.toml.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Chores
    • Updated Solidity compiler settings for improved optimization and compatibility.
    • Removed outdated compiler versions and RPC endpoints from configuration files.
    • Upgraded the "@kleros/vea-contracts" dependency to version ^0.7.0.

@jaybuidl jaybuidl requested a review from a team as a code owner August 7, 2025 13:48
Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for kleros-v2-testnet ready!

Name Link
🔨 Latest commit e41ee56
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-testnet/deploys/6894ae98a9db44000879d4ab
😎 Deploy Preview https://deploy-preview-2073--kleros-v2-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for kleros-v2-university failed. Why did it fail? →

Name Link
🔨 Latest commit e41ee56
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-university/deploys/6894ae9840a8ad0008ea9570

Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for kleros-v2-neo ready!

Name Link
🔨 Latest commit e41ee56
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-neo/deploys/6894ae98ac2b4100087fb3f4
😎 Deploy Preview https://deploy-preview-2073--kleros-v2-neo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Aug 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update modifies configuration files for the contracts project. It adjusts Solidity compiler settings in both Foundry and Hardhat configs, including optimizer runs and viaIR options, and updates a dependency version in package.json. No changes to source code or exported entities are present.

Changes

Cohort / File(s) Change Summary
Foundry Compiler Config
contracts/foundry.toml
Set Solidity compiler version to 0.8.30, enabled viaIR and optimizer (500 runs) with Yul stack allocation, added a "tests" profile disabling viaIR, restricted viaIR for a specific test file, and removed Arbitrum Goerli and Goerli RPC endpoints.
Hardhat Compiler Config
contracts/hardhat.config.ts
Removed Solidity 0.8.24 compiler config; increased optimizer runs for 0.8.30 from 100 to 10000; other settings unchanged.
Dependency Update
contracts/package.json
Updated @kleros/vea-contracts dependency from version ^0.6.0 to ^0.7.0.

Sequence Diagram(s)

Not applicable: The changes are limited to configuration and dependency updates, with no new or modified control flow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

Type: Maintenance :construction:

Poem

A hop and a skip, configs align,
The compiler now sharper, the settings refined.
Dependencies fresh, the code will compile,
This rabbit approves with a whiskery smile.
Onward we leap, with Solidity bright,
Our contracts prepared for the next test flight! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0cdc07d and e41ee56.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • contracts/foundry.toml (1 hunks)
  • contracts/hardhat.config.ts (1 hunks)
  • contracts/package.json (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/solc-0.8.30-viaIR-foundry

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jaybuidl jaybuidl linked an issue Aug 7, 2025 that may be closed by this pull request
@jaybuidl jaybuidl merged commit 9b1f5fd into dev Aug 7, 2025
8 of 18 checks passed
Copy link

sonarqubecloud bot commented Aug 7, 2025

Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for kleros-v2-testnet-devtools ready!

Name Link
🔨 Latest commit e41ee56
🔍 Latest deploy log https://app.netlify.com/projects/kleros-v2-testnet-devtools/deploys/6894ae98030c5b0008d02d58
😎 Deploy Preview https://deploy-preview-2073--kleros-v2-testnet-devtools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contracts: enable IR compilation pipeline with Foundry
1 participant