Remove unused LogicalScanNodeTable's properties #5055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
reviewed
Mar 15, 2025
| @@ -20,6 +20,7 @@ | |||
| #include "planner/operator/persistent/logical_insert.h" | |||
| #include "planner/operator/persistent/logical_merge.h" | |||
| #include "planner/operator/persistent/logical_set.h" | |||
| #include <planner/operator/scan/logical_scan_node_table.h> | |||
There was a problem hiding this comment.
change <> to "" for consistency
| std::make_shared<LogicalProjection>(std::move(expressions), op->getChild(childIdx)); | ||
| auto child = op->getChild(childIdx); | ||
| // reset scan node table properties | ||
| if (child->getOperatorType() == LogicalOperatorType::SCAN_NODE_TABLE) { |
There was a problem hiding this comment.
I would add a new optimizer that remove any unnecessary projection instead of coupling the logic inside projection push down optimizer.
| if (scanNodeTable.getProperties().empty()) { | ||
| return false; | ||
| } | ||
| bool hasPropertiesInUse = false; |
There was a problem hiding this comment.
First I wanna understand on which query this optimization will take effect so that we can add test & benchmark.
Second, I think we can do better than clearProperty. Scan operator can scan a subset of its current properties.
| @@ -36,8 +37,18 @@ void PrimaryKeyScanNodeTable::initLocalStateInternal(ResultSet* resultSet, | |||
| for (auto& pos : info.outVectorsPos) { | |||
| outVectors.push_back(resultSet->getValueVector(pos).get()); | |||
| } | |||
| scanState = std::make_unique<NodeTableScanState>( | |||
| resultSet->getValueVector(info.nodeIDPos).get(), outVectors, outVectors[0]->state); | |||
| if (outVectors.empty()) { | |||
There was a problem hiding this comment.
@ray6080 should review this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributor agreement