Clean up numpy dependencies and speed up 3.13 CI with numpy>=2.1.0
#30714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
sydney-runkle
changed the title
numpy >= 2.1.0 for Python 3.13numpy >= 2.1.0 for Python 3.13
This was referenced Apr 7, 2025
sydney-runkle
commented
Apr 7, 2025
sydney-runkle
commented
Apr 7, 2025
Also, remove unnecessary numpy testing deps, ensuring min version isn't bumped for chroma.
sydney-runkle
force-pushed
the
unpin-numpy
branch
from
75ce6c3 to
4dad661
Compare
sydney-runkle
changed the title
numpy >= 2.1.0 for Python 3.13numpy dependencies and speed up 3.13 CI with numpy >=2.1.0
ccurme
approved these changes
Apr 7, 2025
sydney-runkle
force-pushed
the
unpin-numpy
branch
from
6d43e60 to
4bc21f2
Compare
sydney-runkle
changed the title
numpy dependencies and speed up 3.13 CI with numpy >=2.1.0numpy dependencies and speed up 3.13 CI with numpy>=2.1.0
eyurtsev
approved these changes
Apr 8, 2025
ccurme
approved these changes
Apr 8, 2025
|
Hi @sydney-runkle, as this PR fixes this issue but this version is not yet available on pypi |
|
Hi! We should be releasing shortly! |
|
Should be fixed in |
|
Hi sydney-runkle, the issue is fixed now. Thanks . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, this PR is CI performance focused + aims to clean up some dependencies at the same time.
numpyin allpyproject.tomlfiles wherenumpyis specifiednumpy >= 2.1.0for Python 3.13 andnumpy > v1.26.0for Python 3.12, plus anumpymin version bump forchromanumpy < 2.1.0was taking ~3 minutes, now the entire env setup takes a few secondsnumpytest dependency from partners where that was not used, specificallyhuggingface,voyageai,xai, andnomic.It's a bit unfortunate that
langchain-communitydepends onnumpy, we might want to try to fix that in the future...Closes #26026
Fixes #30555