Skip to content

Conversation

sadra-barikbin
Copy link
Contributor

@sadra-barikbin sadra-barikbin commented Jul 26, 2025

Allow addingPromptTemplates with formats other than f-string. Fixes #32151

@sadra-barikbin sadra-barikbin requested a review from eyurtsev as a code owner July 26, 2025 22:28
Copy link

vercel bot commented Jul 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Sep 8, 2025 7:16pm

Copy link

codspeed-hq bot commented Jul 26, 2025

CodSpeed WallTime Performance Report

Merging #32253 will not alter performance

Comparing sadra-barikbin:feature/support-for-add-in-prompt_template (e72a8e3) with master (390606c)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Jul 26, 2025

CodSpeed Instrumentation Performance Report

Merging #32253 will not alter performance

Comparing sadra-barikbin:feature/support-for-add-in-prompt_template (e72a8e3) with master (390606c)

Summary

✅ 14 untouched benchmarks

@mdrxy mdrxy added the core Related to the package `langchain-core` label Jul 28, 2025
@eyurtsev
Copy link
Collaborator

@sadra-barikbin overall looks good. Could you offer a few sentences on why you need to add 2 jinja2 prompts rather than just assemble a single prompt from the get-go?

@eyurtsev eyurtsev self-assigned this Jul 29, 2025
@sadra-barikbin
Copy link
Contributor Author

@eyurtsev , Sure. I was to make improvement in a prompt builder class with many private methods each one returning a part of the total prompt, all added up together finally. Changing the way prompt was built to having a huge template file containing the whole prompt was considered a sweeping change.

@eyurtsev eyurtsev force-pushed the feature/support-for-add-in-prompt_template branch from c5048e3 to e72a8e3 Compare September 8, 2025 19:10
@eyurtsev eyurtsev enabled auto-merge (squash) September 8, 2025 19:11
@eyurtsev eyurtsev merged commit 3486d6c into langchain-ai:master Sep 8, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the package `langchain-core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for adding PromptTemplates of Jinja2 template format
3 participants