-
Notifications
You must be signed in to change notification settings - Fork 19k
feat(core): support for adding PromptTemplate
s with formats other than f-string
#32253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): support for adding PromptTemplate
s with formats other than f-string
#32253
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
CodSpeed WallTime Performance ReportMerging #32253 will not alter performanceComparing
|
CodSpeed Instrumentation Performance ReportMerging #32253 will not alter performanceComparing Summary
|
@sadra-barikbin overall looks good. Could you offer a few sentences on why you need to add 2 jinja2 prompts rather than just assemble a single prompt from the get-go? |
@eyurtsev , Sure. I was to make improvement in a prompt builder class with many private methods each one returning a part of the total prompt, all added up together finally. Changing the way prompt was built to having a huge template file containing the whole prompt was considered a sweeping change. |
c5048e3
to
e72a8e3
Compare
Allow adding
PromptTemplate
s with formats other thanf-string
. Fixes #32151