Skip to content

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 3, 2025

No description provided.

Copy link

vercel bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Sep 8, 2025 9:25pm

Copy link

codspeed-hq bot commented Sep 3, 2025

CodSpeed WallTime Performance Report

Merging #32812 will not alter performance

Comparing cbornet:ruff-langchain_v1-e501 (4818a8c) with master (54c2419)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Sep 3, 2025

CodSpeed Instrumentation Performance Report

Merging #32812 will not alter performance

Comparing cbornet:ruff-langchain_v1-e501 (4818a8c) with master (54c2419)

Summary

✅ 14 untouched benchmarks

@mdrxy mdrxy self-assigned this Sep 4, 2025
@mdrxy mdrxy added the linting Linting, formatting, or typing label Sep 4, 2025
@mdrxy mdrxy changed the title chore(langchain): add ruff rule E501 in langchain_v1 chore(langchain): add ruff rule E501 in langchain_v1 Sep 4, 2025
@mdrxy mdrxy added the langchain Related to the package `langchain` label Sep 4, 2025
@cbornet cbornet force-pushed the ruff-langchain_v1-e501 branch from 7c2f994 to c9055ae Compare September 8, 2025 14:49
@mdrxy mdrxy requested a review from Copilot September 8, 2025 21:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enforces the E501 (line too long) linting rule for the langchain/agents/* directory by removing the rule exception and reformatting all long lines to comply with the length limit.

  • Removes E501 exception from the pyproject.toml configuration
  • Splits long string literals and function arguments across multiple lines
  • Reformats docstrings and comments to respect line length limits

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libs/langchain_v1/pyproject.toml Removes E501 exception for agents directory
libs/langchain_v1/langchain/agents/tool_node.py Reformats long strings, comments, and error messages
libs/langchain_v1/langchain/agents/structured_output.py Splits long docstrings and error messages
libs/langchain_v1/langchain/agents/react_agent.py Reformats extensive docstrings and error messages
libs/langchain_v1/langchain/agents/middleware/types.py Splits long docstring
libs/langchain_v1/langchain/agents/middleware/summarization.py Adds noqa comment for template string
libs/langchain_v1/langchain/agents/middleware/prompt_caching.py Reformats docstrings and error messages
libs/langchain_v1/langchain/agents/middleware/human_in_the_loop.py Splits long error message strings
libs/langchain_v1/langchain/agents/interrupt.py Reformats docstring structure

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mdrxy mdrxy merged commit 017348b into langchain-ai:master Sep 8, 2025
40 checks passed
@cbornet cbornet deleted the ruff-langchain_v1-e501 branch September 9, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the package `langchain` linting Linting, formatting, or typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants