wip: modify model request as its own node #6071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
sydney-runkle
commented
Sep 3, 2025
Comment on lines
+474
to
+476
|
|
||
| from langgraph.agent import create_agent | ||
|
|
There was a problem hiding this comment.
Experiencing some import issues, temporary workaround
sydney-runkle
commented
Sep 3, 2025
| @@ -113,7 +168,7 @@ def create_agent( | |||
| [first_node, END], | |||
| ) | |||
| graph.add_conditional_edges( | |||
| last_node, _make_model_to_tools_edge(first_node), ["tools", END] | |||
| last_node, _make_model_to_tools_edge(first_node), [first_node, "tools", END] | |||
There was a problem hiding this comment.
post_model should be able to route to model
sydney-runkle
commented
Sep 3, 2025
Comment on lines
102
to
108
| else: | ||
| model_ = request.model.bind_tools(request.tools, tool_choice=request.tool_choice) | ||
| output = model_.invoke(messages) | ||
| if state.response is not None: | ||
| return {"messages": output, "response": None} | ||
| else: | ||
| return {"messages": output} |
There was a problem hiding this comment.
We need to rebind each time here, also side note, need to add more complex structured output logic from the other agent
|
Closing for now, have ported this over to LC via langchain-ai/langchain#32828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on swarm impl w/ this change to verify architectural value