Skip to content

"weird" hamburger menu with header layout on mobile view #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

"weird" hamburger menu with header layout on mobile view #56

merged 1 commit into from
Feb 28, 2025

Conversation

graphiert
Copy link
Contributor

@graphiert graphiert commented Feb 27, 2025

There is a bit of an unsightly look to the header layout when the hamburger menu is opened on a mobile device, simply need more padding. In this PR, I added padding for the hamburger menu. Maybe this is still for other starter kits, so please review for other starter kits. Thank you.

Before After
Screenshot_20250227_192615.jpg Screenshot_20250227_192150.jpg

@tnylea tnylea added the Approved Approved for Merge label Feb 28, 2025
Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the before and after.

You're right. This happened after we updated the ShadCN components to the latest. Appreciate the fix.

@taylorotwell taylorotwell merged commit 8ec6971 into laravel:main Feb 28, 2025
2 checks passed
JoeyMckenzie pushed a commit to JoeyMckenzie/laravel-official-react-starter-kit that referenced this pull request Mar 2, 2025
lucianodigital2b pushed a commit to lucianodigital2b/clevernote that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved for Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants