Use the latest version of actions/checkout
#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avosalmon
commented
Feb 6, 2025
| @@ -27,7 +27,7 @@ export default function AppearanceToggleDropdown({ className = '', ...props }: H | |||
| <span className="sr-only">Toggle theme</span> | |||
| </Button> | |||
| </DropdownMenuTrigger> | |||
| <DropdownMenuContent align="end" rounded="xl"> | |||
| <DropdownMenuContent align="end"> | |||
There was a problem hiding this comment.
DropdownMenuContent does not have the rounded prop.
| @@ -283,7 +283,7 @@ export default function Welcome() { | |||
| </main> | |||
|
|
|||
| <footer className="py-16 text-center text-sm text-black dark:text-white/70"> | |||
| Laravel v{laravelVersion} (PHP v{phpVersion}) | |||
| Laravel v{laravelVersion as string} (PHP v{phpVersion as string}) | |||
| @@ -12,7 +12,7 @@ export function NavMain({ items = [] }: { items: NavItem[] }) { | |||
| <SidebarMenuItem key={item.title}> | |||
| <SidebarMenuButton asChild isActive={item.url === page.url}> | |||
| <Link href={item.url} prefetch> | |||
| <item.icon /> | |||
| {item.icon && <item.icon />} | |||
|
@tnylea There is an error in
|
|
Thanks @avosalmon! I got the I'll chat more with ya on Slack 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
actions/checkoutin GitHub Actions and fixes some TS errors.