Skip to content

Conversation

jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented May 27, 2020

Closes #45

This PR makes a bunch of small fixes and improvements throughout the app. These are all relatively small issues that have been accumulating over time.

  • update swap loading icon colors to white & gray
  • don't force channel selection when starting a loop. This allows users to perform a swap without needing to specify channels.
  • fix navbar menu icon overlap with page header back arrow
  • add text in Loop History tile when there are no past swaps
  • prevent Loop In when multiple channels are selected using different peers. Also display a message informing the user why the "Loop In" button is disabled
  • pass channel ids with Loop In/Out RPC requests
  • fix findDOMNode console error (react-virtualized)
  • set swap speed based on GetInfo 'chain' field. 30mins for mainnet/testnet, immediate for regtest
  • refactor base styled components into a separate folder than common
  • use big.js package to handle potential JS number overflow problems

@jamaljsr jamaljsr requested a review from guggero May 27, 2020 21:27
@jamaljsr jamaljsr linked an issue May 27, 2020 that may be closed by this pull request
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup. Tested locally with the grub.

@guggero guggero merged commit e88a9bf into master May 29, 2020
@jamaljsr jamaljsr deleted the misc-tweaks branch May 29, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor fixes and tweaks Handle potential JS number overflow issues
2 participants