Skip to content

app: rename client app to Lightning Terminal (LiT) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2020
Merged

app: rename client app to Lightning Terminal (LiT) #78

merged 2 commits into from
Jul 23, 2020

Conversation

jamaljsr
Copy link
Member

This PR builds on top of #77. It updates the README and copy within the app to Lightning Terminal and litd.

@jamaljsr jamaljsr mentioned this pull request Jul 21, 2020
Merged
@jamaljsr jamaljsr force-pushed the rename-app branch 2 times, most recently from a6e35be to 9eed507 Compare July 21, 2020 22:11
Roasbeef
Roasbeef reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, haven't rendered yet locally. Also what about the change in the current main landing page from Lightning Loop to Lightning Terminal?

@jamaljsr jamaljsr force-pushed the rename-app branch 3 times, most recently from c67363c to 791c59e Compare July 22, 2020 23:04
@jamaljsr jamaljsr requested a review from guggero July 23, 2020 02:47
@jamaljsr jamaljsr mentioned this pull request Jul 23, 2020
Merged
guggero
guggero approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jamaljsr jamaljsr merged commit a06c48f into master Jul 23, 2020
@jamaljsr jamaljsr deleted the rename-app branch July 23, 2020 16:39
@RyanPaul31 RyanPaul31 mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef left review comments

+1 more reviewer

@guggero guggero guggero approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamaljsr @Roasbeef @guggero