[custom channels]: Use new tapchannelrpc RPC methods
#807
Conversation
guggero
force-pushed
the
tap-channel-rpcs
branch
from
9140cc0 to
3fa4a1d
Compare
guggero
force-pushed
the
tap-channel-rpcs
branch
2 times, most recently
from
81bb790 to
a19321f
Compare
|
I tested all commands manually, everything seems to work as expected. Ready for full review now. |
| return m.invoiceChan, m.invoiceErrChan, nil | ||
| } | ||
|
|
||
| type mockRouter struct { |
There was a problem hiding this comment.
I think we should add a bit more to this commit message. I'm not certain what's happening here. I think you're removing functionality from the LND mock and putting it into a new mock called mockRouter.
Is that split related to the lndclient version bump?
There was a problem hiding this comment.
+1, fully understand the diff but missing rationale/context
There was a problem hiding this comment.
Added some rationale to the commit message.
itest/assets_test.go
Outdated
| t, src, dst, btcutil.Amount(htlcCarrierAmt), | ||
| encodeResp.CustomRecords, | ||
| ) | ||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
Unnecessary sleep? Shouldn't getAssetPaymentResult block on the recv?
There was a problem hiding this comment.
Unfortunately and strangely the tests fail without it... It shouldn't make a difference, but somehow it does. Moved it to a single place and added an explanatory comment.
| return m.invoiceChan, m.invoiceErrChan, nil | ||
| } | ||
|
|
||
| type mockRouter struct { |
There was a problem hiding this comment.
+1, fully understand the diff but missing rationale/context
Because each lndclient service mock now needs to implement the RawClientWithMacAuth method but with a different type, we can't implement two lndclient service mocks within a single struct, as that would require us to have two methods with the same name but different types. So we split the lnd and rounter mocks into two separate structs.
guggero
force-pushed
the
tap-channel-rpcs
branch
2 times, most recently
from
aeedc66 to
734627b
Compare
guggero
force-pushed
the
tap-channel-rpcs
branch
3 times, most recently
from
ed56dd9 to
d8c4d4d
Compare
With this commit we bump to the latest version of taproot assets and lnd (staging branch), so we can use the new SendPayment RPC that handles the RFQ part inline.
guggero
force-pushed
the
tap-channel-rpcs
branch
from
d8c4d4d to
8853d2c
Compare
Depends on lightninglabs/taproot-assets#1048.
Depends on lightningnetwork/lnd#8947.Uses the new
tapchannelrpcRPC methodsSendPaymentandAddInvoicethat do the RFQ part inline, so we don't have to keep that logic in thelitclicode.