Skip to content

Revert "[Support] Error if SocketPath is too long" #149096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

citymarina
Copy link
Contributor

@llvmbot
Copy link
Member

llvmbot commented Jul 16, 2025

@llvm/pr-subscribers-llvm-support

Author: Marina Taylor (citymarina)

Changes

Reverts llvm/llvm-project#148903 due to bot failure https://lab.llvm.org/buildbot/#/builders/187/builds/8162


Full diff: https://github.com/llvm/llvm-project/pull/149096.diff

1 Files Affected:

  • (modified) llvm/lib/Support/raw_socket_stream.cpp (-8)
diff --git a/llvm/lib/Support/raw_socket_stream.cpp b/llvm/lib/Support/raw_socket_stream.cpp
index cf51de889deaf..fd1c681672138 100644
--- a/llvm/lib/Support/raw_socket_stream.cpp
+++ b/llvm/lib/Support/raw_socket_stream.cpp
@@ -119,14 +119,6 @@ ListeningSocket::ListeningSocket(ListeningSocket &&LS)
 Expected<ListeningSocket> ListeningSocket::createUnix(StringRef SocketPath,
                                                       int MaxBacklog) {
 
-  // If SocketPath is too long, the path will be truncated, and there may be
-  // collisions with other truncated addresses that the fs::exists check below
-  // will be unable to detect.
-  if (SocketPath.size() >= sizeof(sockaddr_un::sun_path))
-    return llvm::make_error<StringError>(
-        std::make_error_code(std::errc::filename_too_long),
-        "SocketPath too long");
-
   // Handle instances where the target socket address already exists and
   // differentiate between a preexisting file with and without a bound socket
   //

@citymarina citymarina merged commit dd3d26b into main Jul 16, 2025
11 checks passed
@citymarina citymarina deleted the revert-148903-socket-truncate branch July 16, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants