Skip to content

AMDGPU: Remove the dot4 test in insert-delay-alu-wmma-xdl.mir, NFC #149375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

changpeng
Copy link
Contributor

@changpeng changpeng commented Jul 17, 2025

This is irrelevant, and caused a failure in downstream.

Fixes: SWDEV-544025

 This is irrelevant, and caused a failure in downstream.
@llvmbot
Copy link
Member

llvmbot commented Jul 17, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Changpeng Fang (changpeng)

Changes

This is irrelevant, and caused a failure in downstream.


Full diff: https://github.com/llvm/llvm-project/pull/149375.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/AMDGPU/insert-delay-alu-wmma-xdl.mir (-17)
diff --git a/llvm/test/CodeGen/AMDGPU/insert-delay-alu-wmma-xdl.mir b/llvm/test/CodeGen/AMDGPU/insert-delay-alu-wmma-xdl.mir
index 7c3170d8d1e9f..0abf34797a5e7 100644
--- a/llvm/test/CodeGen/AMDGPU/insert-delay-alu-wmma-xdl.mir
+++ b/llvm/test/CodeGen/AMDGPU/insert-delay-alu-wmma-xdl.mir
@@ -65,20 +65,3 @@ body: |
     $vgpr12 = V_EXP_F32_e32 $vgpr12, implicit $exec, implicit $mode
     $vgpr13 = V_ADD_U32_e32 $vgpr13, $vgpr8, implicit $exec
 ...
-
----
-name: dot_xdl_dep_2
-tracksRegLiveness: true
-body: |
-  bb.0:
-    ; CHECK-LABEL: {{^}}dot_xdl_dep_2:
-    ; CHECK: %bb.0:
-    ; CHECK-NEXT: v_dot4_i32_iu8 v0, s2, s3, v0 neg_lo:[1,1,0]
-    ; CHECK-NEXT: v_dot4_i32_iu8 v1, s2, s3, v2 neg_lo:[1,1,0]
-    ; CHECK-NEXT: s_delay_alu instid0(VALU_DEP_2)
-    ; CHECK-NEXT: v_add_nc_u32_e32 v2, v0, v0
-    liveins: $vgpr0, $sgpr2, $sgpr3, $vgpr0, $vgpr1, $vgpr2
-    $vgpr0 = V_DOT4_I32_IU8 9, $sgpr2, 9, $sgpr3, 8, $vgpr0, 0, 0, 0, implicit $exec
-    $vgpr1 = V_DOT4_I32_IU8 9, $sgpr2, 9, $sgpr3, 8, $vgpr2, 0, 0, 0, implicit $exec
-    $vgpr2 = V_ADD_U32_e32 $vgpr0, $vgpr0, implicit $exec
-...

@changpeng changpeng requested review from rampitec and shiltian July 17, 2025 18:26
@shiltian
Copy link
Contributor

Honestly I don't follow…

@changpeng
Copy link
Contributor Author

Honestly I don't follow…
This is related to PR: #149208, specifically the following piece of code:

// WMMA XDL ops are treated the same as TRANS.
if (AMDGPU::isGFX1250(*ST) && SII->isXDLWMMA(MI))
return TRANS;

The DOT instruction test is not relevant. But this test is causing a failure in one of the downstream branch.
The reason the DOT instruction check was there is because people once though DOT can also be treated as a TRAN,
and later confirmed not. Thus that is in an intermediate state.

@changpeng changpeng merged commit 70046cd into llvm:main Jul 17, 2025
11 checks passed
@changpeng changpeng deleted the dot4 branch July 17, 2025 21:26
@arsenm
Copy link
Contributor

arsenm commented Jul 17, 2025

Honestly I don't follow…
This is related to PR: #149208, specifically the following piece of code:

// WMMA XDL ops are treated the same as TRANS. if (AMDGPU::isGFX1250(*ST) && SII->isXDLWMMA(MI)) return TRANS;

The DOT instruction test is not relevant. But this test is causing a failure in one of the downstream branch. The reason the DOT instruction check was there is because people once though DOT can also be treated as a TRAN, and later confirmed not. Thus that is in an intermediate state.

Then the test should remain as a negative test

@changpeng
Copy link
Contributor Author

Honestly I don't follow…
This is related to PR: #149208, specifically the following piece of code:

// WMMA XDL ops are treated the same as TRANS. if (AMDGPU::isGFX1250(*ST) && SII->isXDLWMMA(MI)) return TRANS;
The DOT instruction test is not relevant. But this test is causing a failure in one of the downstream branch. The reason the DOT instruction check was there is because people once though DOT can also be treated as a TRAN, and later confirmed not. Thus that is in an intermediate state.

Then the test should remain as a negative test
The failure is root-caused to instruction format changes, and has been exposed by other tests already. @jun Wang is working on it. We should not keep the test in a irrelevant category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants