Skip to content

migrate to localstack auth login #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

migrate to localstack auth login #59

merged 1 commit into from
Apr 23, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Apr 23, 2024 •
edited
Loading

Motivation

localstack login has been deprecated in favor of localstack auth login for quite a while (at least 3.0).

Changes

This PR changes the usages of localstack login in this repo to localstack auth login.

@alexrashed alexrashed added the documentation Improvements or additions to documentation label Apr 23, 2024
@alexrashed alexrashed self-assigned this Apr 23, 2024
@alexrashed alexrashed requested review from thrau and giograno April 23, 2024 07:26
thrau
thrau approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks alex! localstack login actually isn't required anymore to use extensions, all you need is a valid auth token. i'll update the README as a follow-up PR :-)

@thrau thrau merged commit ae073f2 into main Apr 23, 2024
@thrau thrau deleted the migrate-to-auth-login branch April 23, 2024 10:52
@giograno
Copy link
Member

thanks alex! localstack login actually isn't required anymore to use extensions, all you need is a valid auth token. i'll update the README as a follow-up PR :-)

A small addition to the conversation. AFIK, I am not sure we have any feature that requires login anymore. Also pods just require a valid auth token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@giograno giograno Awaiting requested review from giograno

Assignees

@alexrashed alexrashed

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @giograno @thrau