This repository was archived by the owner on Jun 27, 2022. It is now read-only.
Update backends.py #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding AD_GROUP_FILTER
marcus-crane
suggested changes
Nov 8, 2021
| @@ -99,6 +99,9 @@ def _configure_access_groups(self, user, access_token): | |||
| azure_group_names = [entry.get('displayName') for entry in azure_groups] | |||
| AD_GROUP_MAP = PLUGIN_SETTINGS.get('AD_GROUP_MAP', {}) | |||
| for group_name in azure_group_names: | |||
| if group_name not in PLUGIN_SETTINGS['AD_GROUP_FILTER']: | |||
There was a problem hiding this comment.
I would first check if PLUGIN_SETTINGS['AD_GROUP_FILTER'] is defined. I can imagine AD_GROUP_FILTER being initialised as an empty list and then for users who upgrade but don't define a filter, suddenly all groups are filtered out because nothing is in the filter list!
|
Hey @tatsuyaueda, thanks for taking the time to submit a pull request 🙂 It looks good! There's a small change I would make just to ensure that users who upgrade to a new version aren't accidentally impacted |
|
Ahh, I'll need to write some documentation for this anyway so I'll just merge it in and add the check. Thanks again |
|
Thanks. I didn't care enough about the code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10
Adding AD_GROUP_FILTER