[TypeScript] Export ValidationMessageFuncParams and ValidationMessageFunc types
#10867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Jul 29, 2025
| args: any; | ||
| value: any; | ||
| values: any; | ||
| } | ||
|
|
||
| type MessageFunc = (params: MessageFuncParams) => ValidationErrorMessage; | ||
| export type ValidationMessageFunc = ( |
There was a problem hiding this comment.
No a big fan of this name. I suggest ValidationMessageFactory, GetValidationMessage, or GenerateValidationMessage. Append Params for the second type.
fzaninotto
approved these changes
Jul 30, 2025
fzaninotto
changed the title
ValidationMessageFuncParams and ValidationMessageFunc typesValidationMessageFuncParams and ValidationMessageFunc types
fzaninotto
changed the title
ValidationMessageFuncParams and ValidationMessageFunc typesValidationMessageFuncParams and ValidationMessageFunc types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some users need those types but they are not exported so they had to duplicate them in their code.
Solution
Export them with better names.
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature