Optimize Budget model performance by preventing N+1 queries #2504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed N+1 query issue in method that was causing excessive database calls - Optimized category lookups by pre-computing category totals with for O(1) lookup - Added explicit to prevent redundant category association loads - Applied same optimization to method - Added comprehensive test coverage to verify performance improvements - These changes significantly reduce database queries when rendering budget donut charts Performance Impact: - Before: N budget_categories × 2 queries (category + expense lookup) = 2N queries per chart - After: 2 total queries (1 preload + 1 expense totals) regardless of category count This optimization is especially impactful for users with many budget categories, reducing response time and database load on budget-related pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Budget model was suffering from N+1 query issues, leading to excessive database calls and performance degradation when rendering budget donut charts.
Before Optimization
budget_categoryand itscategoryseparatelySolution
index_byfor O(1) lookup.includes(:category)explicitly to ensure categories are preloaded, reducing query count.allocated_spendingmethod.After Optimization
budget_categoryImpact
This optimization is expected to significantly improve performance for users with many budget categories by reducing:
Testing
Added comprehensive test coverage to validate no regression in behavior and verified query count reduction.