[WC-2984] Events: Parameter type support #1771
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter type support
… in delay and repeat properties
gjulivan
reviewed
Jul 14, 2025
gjulivan
reviewed
Jul 15, 2025
r0b1n
reviewed
Jul 15, 2025
r0b1n
reviewed
Jul 15, 2025
r0b1n
reviewed
Jul 15, 2025
packages/pluggableWidgets/events-web/src/__tests__/AppEvents.spec.tsx
Outdated
Show resolved
Hide resolved
r0b1n
reviewed
Jul 15, 2025
…ay and interval values
gjulivan
reviewed
Jul 15, 2025
packages/pluggableWidgets/events-web/src/hooks/delayAndInterval.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jul 15, 2025
gjulivan
reviewed
Jul 15, 2025
There was a problem hiding this comment.
we can remove this file, right?
yordan-st
force-pushed
the
feat/WC-298_events-parameter-type-support
branch
from
8f741af to
0f7af88
Compare
gjulivan
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
When configuring the Events widget to run specific action on load or on attribute change, previously user only could set a static value when setting the delay value or repeat interval.
I enhanced this by adding a the possibility to set these value with expressions. This way users have more flexibility when configuring their events.
What should be covered while testing?