crowdin github actions - update directory paths for source files #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
Updates file paths for internationalization (i18n) configuration to reflect a new directory structure, moving source files from the root i18n/ directory to packages/web/public/i18n/.
- Updated GitHub workflow trigger paths to monitor the new location
- Adjusted Crowdin configuration source and translation paths
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/crowdin-upload-sources.yml | Updated workflow trigger path to monitor i18n files in new location |
| packages/web/crowdin.yml | Updated source and translation paths for Crowdin configuration |
| @@ -5,7 +5,7 @@ on: | |||
| # Monitor all .json files within the /i18n/locales/en/ directory. | |||
There was a problem hiding this comment.
The comment still references the old directory path '/i18n/locales/en/' but the actual path has been updated to '/packages/web/public/i18n/locales/en/'. The comment should be updated to match the new path.
Suggested change
| # Monitor all .json files within the /i18n/locales/en/ directory. | |
| # Monitor all .json files within the /packages/web/public/i18n/locales/en/ directory. |
Copilot uses AI. Check for mistakes.
danditomaso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates paths related to internationalization (i18n) files to reflect a new directory structure. The changes ensure that workflows and configurations correctly reference the updated file locations.
Updates to i18n file paths:
.github/workflows/crowdin-upload-sources.yml: Updated the workflow to monitor.jsonfiles in the newpackages/web/public/i18n/locales/en/directory instead of the oldi18n/locales/en/directory.packages/web/crowdin.yml: Adjusted thesourceandtranslationpaths to align with the new directory structure, changing fromi18n/localestopublic/i18n/locales.Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)