Repo: Update to the 2024 edition #1425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
force-pushed
the
edition-2024
branch
2 times, most recently
from
27ad5d3 to
33224bf
Compare
smalis-msft
force-pushed
the
edition-2024
branch
from
33224bf to
ec83aa6
Compare
|
Let's please wait until we are further along with the current release. |
|
Now that 1.88 is out this is blocking us gaining access to if let chains. |
smalis-msft
force-pushed
the
edition-2024
branch
3 times, most recently
from
447bbbc to
8df548b
Compare
smalis-msft
force-pushed
the
edition-2024
branch
from
7704c10 to
fd83b7a
Compare
smalis-msft
force-pushed
the
edition-2024
branch
from
e70250f to
cdbd46d
Compare
smalis-msft
force-pushed
the
edition-2024
branch
from
cdbd46d to
2261055
Compare
smalis-msft
force-pushed
the
edition-2024
branch
from
2261055 to
dcc1aba
Compare
smalis-msft
force-pushed
the
edition-2024
branch
from
dcc1aba to
f3655be
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Rust project from the 2021 edition to the 2024 edition, addressing compatibility warnings and removing temporary lint suppressions. The update introduces minor lint issues that are fixed throughout the codebase.
- Updates workspace and package configurations to use the 2024 edition
- Fixes lint issues related to unnecessary variable assignments and simplified return statements
- Updates
std::future::Futurereferences to use the shorterFuturetype alias - Removes
unsafefunction usage warnings by adding properunsafeblocks
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| xsync/Cargo.toml | Updates workspace edition to 2024 |
| Cargo.toml | Updates workspace edition to 2024 and removes 2024 compatibility lint suppressions |
| Guide/mdbook-openvmm-shim/Cargo.toml | Updates package edition to 2024 |
| Multiple .rs files | Simplifies return expressions and variable assignments per 2024 edition lints |
| Future-related files | Updates std::future::Future to Future for conciseness |
| support/mesh/mesh_process/src/lib.rs | Adds proper unsafe block for std::env::remove_var call |
smalis-msft
force-pushed
the
edition-2024
branch
from
f3655be to
8bcd543
Compare
smalis-msft
force-pushed
the
edition-2024
branch
from
8bcd543 to
61208d1
Compare
chris-oo
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have spot checked about 50 of the 300-ish hits the remaining lints have, as well as manually searching for known potentially problematic patterns, and am relatively certain that the drop order changes will not affect us. Thus the last blocker is removed, and we can update. This naturally introduced a few new minor lint issues, so those are fixed here.
Closes #288