Skip to content

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jul 21, 2025

We internally use TLSSocket.authorized to check if a client's certificate is valid. If its expired, its not valid anymore. This PR moves the commands from the README.md to the generate.sh and sets the lifetime to 10y.

This fixes tests: npm run ctest client-certificates because the certs were expired.

@@ -0,0 +1,86 @@
# Client Certificate test-certificates

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a description to the test file that uses the certificates on when and how the certificates should be regenerated. Or maybe keep the readme and put a short description in it.

@mxschmitt mxschmitt merged commit 0a39587 into microsoft:main Jul 21, 2025
32 checks passed
@mxschmitt mxschmitt deleted the test/fix-client-certificate-tests branch July 21, 2025 16:45
Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node24-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

46758 passed, 926 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants