Skip to content

Fix signature help crash #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 6, 2025
Merged

Fix signature help crash #1527

merged 7 commits into from
Aug 6, 2025

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Aug 6, 2025 •
edited
Loading

No test caught this, but it's a trivially correct port is not so trivial because we were missing the VS Code side of this code.

Fixes #1415
Fixes #1421

Copilot

This comment was marked as outdated.

Sign in to view

@jakebailey
Copy link
Member Author

Maybe this is #1415/#1421?

@jakebailey
Copy link
Member Author

Yeah, it totally is. Will try and make a test.

@jakebailey
Copy link
Member Author

Testing this requires signatureHelpPresentForTriggerReason to be ported in the fourslash test, because we only test sig help baselines without context and this bug requires context.

@jakebailey jakebailey requested a review from andrewbranch August 6, 2025 21:50
@jakebailey jakebailey enabled auto-merge August 6, 2025 22:02
@jakebailey jakebailey mentioned this pull request Aug 6, 2025
Closed
@jakebailey jakebailey added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 29441f1 Aug 6, 2025
22 checks passed
@jakebailey jakebailey deleted the jabaile/fix-sig-help-crash branch August 6, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@gabritto gabritto Awaiting requested review from gabritto

@navya9singh navya9singh Awaiting requested review from navya9singh

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signature help crash when closing parenthesis is typed too quickly Signature help crash on parenthesized call
3 participants
@jakebailey @DanielRosenwasser @andrewbranch