fix: display test snapshot error message #4091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Aug 6, 2025
| @@ -78,18 +78,6 @@ We provide a git pre-commit hook to format and check the code, to install it run | |||
| We use [mockgen](go.uber.org/mock) to handle mocking in our unit tests. | |||
| If you need a new mock please update or add the `//go:generate` instruction to the appropriate file. | |||
|
|
|||
| #### Compilation in VSCode | |||
There was a problem hiding this comment.
[q] why are we removing this?
There was a problem hiding this comment.
I've removed the tags, no need to setup this anymore
blva
reviewed
Aug 6, 2025
| @@ -317,8 +317,6 @@ jobs: | |||
| config: ${{ vars.PERMISSIONS_CONFIG }} | |||
| - name: Checkout repository | |||
| uses: actions/checkout@v4 | |||
| with: | |||
There was a problem hiding this comment.
[q] for my own learning, why are we removing this?
There was a problem hiding this comment.
I see no need to download the full history here
blva
previously approved these changes
Aug 6, 2025
blva
approved these changes
Aug 6, 2025
blva
pushed a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
display test snapshot error message
Jira ticket: CLOUDP-#
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments