jsoncpp: correct name of static library #22585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sharkwouter
approved these changes
Nov 19, 2024
|
It seems this change was made in this PR to enable Clang to work: open-source-parsers/jsoncpp#1480 Maybe upstream has an idea on how to make this condition only activate for MSVC and Clang instead of every WIN32 build. |
|
A better condition for upstream would probably be |
|
Thank you for testing and for digging up that PR. I created a PR for upstream with a change that should work with any compiler when targeting MSVC: open-source-parsers/jsoncpp#1579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22584.