Skip to content

Conversation

tobias-jarvelov
Copy link
Contributor

@tobias-jarvelov tobias-jarvelov commented Sep 4, 2025

Refactors the giant component SplitTunnelingSettings into a view:

  • Extract existing components to their own file.
  • Break up large components into smaller components.
    • Use the useShow pattern as per the styleguide draft.
  • Extract logic into hooks, where sensible and possible.
  • Add contexts to avoid prop drilling and make hooks independent.
  • Styled components are placed inside the React component which uses them.

The functionality and logic is the same and essentially everything is kept "as is" apart from minor name tweaks and that large components have been split up into separate components, with their own subcomponents and hooks.


This change is Reviewable

@tobias-jarvelov tobias-jarvelov force-pushed the refactor-split-tunneling branch 2 times, most recently from 075384e to 0260213 Compare September 4, 2025 11:00
@tobias-jarvelov tobias-jarvelov changed the title Refactor split tunneling WIP Refactor split tunneling Sep 4, 2025
@tobias-jarvelov tobias-jarvelov marked this pull request as draft September 4, 2025 11:02
@tobias-jarvelov tobias-jarvelov changed the title WIP Refactor split tunneling WIP: Refactor split tunneling Sep 4, 2025
@tobias-jarvelov tobias-jarvelov force-pushed the refactor-split-tunneling branch 2 times, most recently from f0976b4 to 3df0516 Compare September 4, 2025 11:11
@tobias-jarvelov tobias-jarvelov force-pushed the refactor-split-tunneling branch from 670c340 to c2c4533 Compare September 5, 2025 13:15
@tobias-jarvelov tobias-jarvelov force-pushed the refactor-split-tunneling branch 2 times, most recently from 89fb0b1 to 2f5233e Compare September 5, 2025 13:53
@tobias-jarvelov tobias-jarvelov force-pushed the refactor-split-tunneling branch from 2f5233e to c242945 Compare September 5, 2025 13:59
@tobias-jarvelov tobias-jarvelov changed the title WIP: Refactor split tunneling Refactor split tunneling Sep 5, 2025
@tobias-jarvelov tobias-jarvelov marked this pull request as ready for review September 5, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant