-
Notifications
You must be signed in to change notification settings - Fork 429
Refactor split tunneling #8708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tobias-jarvelov
wants to merge
4
commits into
main
Choose a base branch
from
refactor-split-tunneling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor split tunneling #8708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
075384e
to
0260213
Compare
f0976b4
to
3df0516
Compare
tobias-jarvelov
commented
Sep 4, 2025
desktop/packages/mullvad-vpn/src/renderer/components/views/split-tunneling/SplitTunneling.tsx
Outdated
Show resolved
Hide resolved
...rc/renderer/components/views/split-tunneling/components/application-icon/ApplicationIcon.tsx
Outdated
Show resolved
Hide resolved
.../renderer/components/views/split-tunneling/components/application-label/ApplicationLabel.tsx
Outdated
Show resolved
Hide resolved
...rc/renderer/components/views/split-tunneling/components/application-list/ApplicationList.tsx
Outdated
Show resolved
Hide resolved
.../src/renderer/components/views/split-tunneling/components/application-row/ApplicationRow.tsx
Outdated
Show resolved
Hide resolved
...ux-application-list/components/linux-application-row/components/warning-icon/WarningIcon.tsx
Outdated
Show resolved
Hide resolved
...s/linux-settings/components/linux-application-list/components/linux-application-row/types.ts
Outdated
Show resolved
Hide resolved
...src/renderer/components/views/split-tunneling/components/no-search-result/NoSearchResult.tsx
Outdated
Show resolved
Hide resolved
.../views/split-tunneling/components/settings/components/application-lists/ApplicationLists.tsx
Outdated
Show resolved
Hide resolved
670c340
to
c2c4533
Compare
89fb0b1
to
2f5233e
Compare
2f5233e
to
c242945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the giant component
SplitTunnelingSettings
into aview
:useShow
pattern as per the styleguide draft.The functionality and logic is the same and essentially everything is kept "as is" apart from minor name tweaks and that large components have been split up into separate components, with their own subcomponents and hooks.
This change is