-
Notifications
You must be signed in to change notification settings - Fork 43.5k
feat(Gitlab Node): Support MR Approve/Unapprove #17555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic analysis
1 issue found across 1 file • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
Hey @ngoyal16, Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request. Before we can proceed, please ensure the following: Regarding new nodes: If your node integrates with an AI service that you own or represent, please email nodes@n8n.io and we will be happy to discuss the best approach. About review timelines: Thank you again for contributing to n8n. |
@@ -1707,6 +1759,19 @@ export class Gitlab implements INodeType { | |||
} | |||
endpoint = `${baseEndpoint}/repository/tree`; | |||
} | |||
} else if (resource === 'mergeRequest') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some tests for these new operations?
Unfortunately we don't have tests for his node yet. You can check out the Youtube.node.test.ts
or Github.node.test.ts
for examples on how we test similar nodes.
Summary
Adds support for approve/unapprove a merge request in the Gitlab node.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)