fix(editor): Case-sensitive credential search in NodeCredentials component
#17564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
RicardoE105
changed the title
NodeCredentials component
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files. Review in cubic
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
RicardoE105
changed the title
NodeCredentials componentNodeCredentials component
CharlieKolb
approved these changes
Jul 28, 2025
|
E2E Tests: n8n tests passed after 5m 7.6s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
RicardoE105
deleted the
ado-3859-credential-search-does-not-work-correctly-with-lower-and
branch
Merged
|
Got released with |
cstuncsik
pushed a commit
that referenced
this pull request
Aug 1, 2025
despairblue
pushed a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the matches() function on line 515, only the haystack parameter (credential name) was converted to lowercase using toLocaleLowerCase(), but the needle parameter (user's search input) remained in its original case.
Before
https://uploads.linear.app/1c35bbc6-9cd4-427e-8bc5-e5d370a9869f/0795b15e-6aaf-420c-9c57-15ac7e887cc6/3b1914c3-57cf-482c-9bc6-ff69bd134a4f
Now
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3859/credential-search-does-not-work-correctly-with-lower-and-uppercasing
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)