Skip to content

Conversation

ivov
Copy link
Member

@ivov ivov commented Aug 15, 2025

Summary

With runners enabled, a Code node that tries to log an object with a readonly property errors out, because of the assignment when replacing circular references when serializing for the RPC call. This can be reproduced with this Code node script:

const testObj = {};
Object.defineProperty(testObj, 'toString', {
 value: function() { return '[readonly]'; },
 writable: false,
 enumerable: true,
 configurable: false
});

console.log(testObj);

return [];

⚠️ Note on testing: Spent a reasonable amount of time trying to write a Vitest test case that reproduces this scenario, but all my attempts either always pass (before and after fix) or always fail (before and after fix). Let me know if you find a way to test this. Else let's move forward as this is a rare case.

Related Linear tickets, Github issues, and Community forum posts

#18328

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 1 file. Review in cubic

Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/workflow/src/utils.ts 28.57% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ivov ivov requested a review from tomi August 15, 2025 11:57
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 15, 2025
@ivov ivov requested a review from tomi August 15, 2025 12:14
Copy link
Collaborator

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

currents-bot bot commented Aug 15, 2025

E2E Tests: n8n tests passed after 4m 20.1s

🟢 519 · 🔴 0 · ⚪️ 0

View Run Details

Run Details

  • Project: n8n

  • Groups: 3

  • Framework: Playwright

  • Run Status: Passed

  • Commit: 615015f

  • Spec files: 108

  • Overall tests: 519

  • Duration: 4m 20.1s

  • Parallelization: 3

Groups

GroupId Results Spec Files Progress
ui 🟢 44 · 🔴 0 · ⚪️ 0 14 / 14
ui:isolated 🟢 6 · 🔴 0 · ⚪️ 0 2 / 2
No name 🟢 469 · 🔴 0 · ⚪️ 0 92 / 92


This message was posted automatically by currents.dev | Integration Settings

@ivov ivov merged commit 3848673 into master Aug 15, 2025
34 checks passed
@ivov ivov deleted the readonly-properties-circular-refs branch August 15, 2025 12:32
This was referenced Aug 18, 2025
@janober
Copy link
Member

janober commented Aug 18, 2025

Got released with n8n@1.108.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants