-
Notifications
You must be signed in to change notification settings - Fork 43.7k
fix(core): Account for readonly properties when replacing circular references #18408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic analysis
No issues found across 1 file. Review in cubic
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
E2E Tests: n8n tests passed after 4m 20.1s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
Got released with |
Summary
With runners enabled, a Code node that tries to log an object with a readonly property errors out, because of the assignment when replacing circular references when serializing for the RPC call. This can be reproduced with this Code node script:
Related Linear tickets, Github issues, and Community forum posts
#18328
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)