Discrete Event Visualization in Timeline #7967
Conversation
…vent-visualization
- Removed in-page `style` defs from ExtendedLinesOverlay.vue; CSS actually located in timeline.scss.
- Improved sizing and style for Marcus Bains ("now") line.
- Removed extraneous padding at bottom of plot view when in Time Strip.
- Added missing header info to timeline.scss.
- CSS refinements.
- Removed bad `}` in TimeSystemAxis.vue. - Removed `.u-contents` from line 129 of ganttChart.e2e.spec.js. - Removed `event-handle` element; not needed. - Changed `__event-wrapper` to not set height explicitly; uses absolute positioning. - Added :before element to event-wrapper for better hit area. - Improved hover styling. - $colorEvent* style constants added to theme constant SCSS files.
- Layout converted to set `min-height` on top-most `c-swimlane` element. Interior containers now use 100% height or absolute positioning. - Removed `c-timeline-holder` from `c-events-tsv` in EventTimelineView.vue; Refactored `c-events-tsv__contents` to be `js-events-tsv` as that was being used as a reference. - New theme constant `eventLineW` sets event lines to be 1px wide for more precision.
…send tick updates
| if (!clientWidth) { | ||
| //this is a hack - need a better way to find the parent of this component | ||
| const parent = this.openmct.layout.$refs.browseObject.$el; | ||
| // Fallback: use the actual container element (the immediate parent) |
There was a problem hiding this comment.
I vaguely recall .parentElement not working in some specific cases for planView, but maybe that's not an issue here. I'll test.
| } | ||
|
|
||
| return { | ||
| key: type, | ||
| name: 'Event Timeline View', | ||
| cssClass: 'icon-event', | ||
| priority: function () { | ||
| return 6000; // big number! | ||
| // We want this to be higher priority than the TelemetryTableView | ||
| return openmct.priority.HIGH + 1; |
There was a problem hiding this comment.
Rather than making the timeline view HIGH + 1 I think we should just make the TelemetryTableView the lowest priority. Like, it's basically the default for all telemetry types.
There was a problem hiding this comment.
There are 3 qualifying views when you're trying to visualize events in the timeline view: Telemetry Table, LAD Table and Event timeline view.
The TelemetryTableView has a priority of 1.
The LAD Table has a priority of HIGH.
The Event timeline has a priority of HIGH+1
This is why it's priority is HIGH+1. I think we need to review view priorities in general though.
|
|
||
| return selection; | ||
| }, | ||
| createSelectionForInspector(event, eventWrapper) { |
There was a problem hiding this comment.
This is still not resolved. We should not be manually constructing the selection path - https://github.com/nasa/openmct/pull/7967/files/32a0e1569144e1b4384c3f7e984a72cc90716823..2e35212c322d851e58b2e96d396166e3948f9538#diff-35593380249d65dcade3df51d2bfe759a597f2e9690e12e001aa8b81f19f6ffbR314
…b.com/nasa/openmct into 7936-add-discrete-event-visualization
Closes #7936
Describe your changes:
Adds a discrete event visualization for the Time Strip object.
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist