Banner Feature Implemented #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e7a507.
|
Revert to banner with list of strings. Please check and accept the pull request. Thanks. |
rwcrowe
requested changes
Aug 27, 2025
There was a problem hiding this comment.
No need to modify this file. I will delete from PR.
| for device in local.devices : [ | ||
| for banner in try(local.device_config[device.name].banner, []) : { | ||
| device_name = device.name | ||
| banner_type = banner.banner_type |
There was a problem hiding this comment.
Can you wrap this in try and reference defaults that we will be adding.
banner_type = try(banner.banner_type, local.defaults.iosxr.configuration.banner_type, null)
| for banner in try(local.device_config[device.name].banner, []) : { | ||
| device_name = device.name | ||
| banner_type = banner.banner_type | ||
| line = banner.line |
There was a problem hiding this comment.
Can you wrap this in try and reference defaults that we will be adding.
line = try(banner.line, local.defaults.iosxr.configuration.banner_line, null)
| device_name = device.name | ||
| banner_type = banner.banner_type | ||
| line = banner.line | ||
| key = "${device.name}-${banner.banner_type}" |
There was a problem hiding this comment.
Can you wrap this in try.
key = try("${device.name}-${banner.banner_type}", null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.