This repository was archived by the owner on Jun 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Helper functions for large ONNX models support #308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
commented
Apr 26, 2023
dbogunowicz
commented
Apr 26, 2023
…com/neuralmagic/sparsezoo into feature/damian/large_models_support
KSGulin
reviewed
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a couple comments
dbogunowicz
commented
May 8, 2023
KSGulin
previously approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 🙂
bfineran
reviewed
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending comments
dbogunowicz
commented
May 8, 2023
bfineran
approved these changes
May 8, 2023
KSGulin
approved these changes
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing onnx helper functions that will be shared across our repositories (deepsparse, sparseml, etc.) to reliably save and validate not only the models which fit into a protobuf (as we did up until now) but also the larger ones (where the large data information is stored in the additional accompanying file).
Did not include the helper function for loading onnx models, since this is not needed if we work under the assumption that the onnx file and the auxiliary data file are in the same directory, see: https://github.com/onnx/onnx/blob/main/docs/ExternalData.md
Related PRs:
neuralmagic/deepsparse#995 (deepsparse)
neuralmagic/sparseml#1540 (sparseml)
Manual testing (only the big model pathway):
Out: